Repository navigation
Run CI on node 18, 20, and 22 - #1480
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1480 +/- ##
=======================================
Coverage ? 80.82%
=======================================
Files ? 53
Lines ? 2216
Branches ? 656
=======================================
Hits ? 1791
Misses ? 421
Partials ? 4 ☔ View full report in Codecov by Sentry. |
I'm fine with that 👍 |
| node-version: | ||
| description: "Node.js version" | ||
| required: false | ||
| default: 20 |
There was a problem hiding this comment.
out of curiosity, why 20 and not 22? ;p
There was a problem hiding this comment.
The initial action sets 20 so I reused that. And in practice/experience, 22 is still prone to accidental breaking changes from node itself, so sticking with 20 feels safer.
| jobs: | ||
| test: | ||
| name: Test | ||
| name: "Test: node-${{ matrix.node_version }}" |
There was a problem hiding this comment.
q: what would be the auto-generated titles without this change?
There was a problem hiding this comment.
I don't quite remember, but searching around and landing at https://stackoverflow.com/questions/69105449/github-actions-job-name-based-on-matrix-index-instead-of-matrix-value. I assume it could look like Test (18)
Co-authored-by: Mateusz Burzyński <[email protected]>
This is the same thing as #1465 but for the
nextbranch. Maybe we should do this only for thenextbranch for now.