Skip to content

Set engines field to node 18 and above - #1479

Merged
Andarist merged 8 commits into
nextfrom
set-engines-field
Oct 17, 2024
Merged

Set engines field to node 18 and above#1479
Andarist merged 8 commits into
nextfrom
set-engines-field

Conversation

@bluwy

@bluwy bluwy commented Oct 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Add

  "engines": {
    "node": ">=18.0.0"
  }

to all package.json

@changeset-bot

changeset-bot Bot commented Oct 5, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2054b7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@changesets/get-version-range-type Minor
@changesets/assemble-release-plan Major
@changesets/get-dependents-graph Major
@changesets/should-skip-package Minor
@changesets/apply-release-plan Major
@changesets/changelog-github Minor
@changesets/get-release-plan Major
@changesets/get-github-info Minor
@changesets/changelog-git Minor
@changesets/release-utils Minor
@changesets/config Major
@changesets/errors Minor
@changesets/logger Minor
@changesets/parse Minor
@changesets/types Major
@changesets/write Minor
@changesets/read Minor
@changesets/cli Major
@changesets/git Major
@changesets/pre Major
@changesets/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Oct 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (next@e0e1748). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1479   +/-   ##
=======================================
  Coverage        ?   81.01%           
=======================================
  Files           ?       54           
  Lines           ?     2239           
  Branches        ?      657           
=======================================
  Hits            ?     1814           
  Misses          ?      421           
  Partials        ?        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Andarist
Andarist reviewed Oct 5, 2024
View reviewed changes
Comment thread .changeset/deep-coins-attend.md Resolved
Andarist
Andarist reviewed Oct 5, 2024
View reviewed changes
Comment thread .codesandbox/ci.json Resolved
Andarist
Andarist reviewed Oct 5, 2024
View reviewed changes
Comment thread babel.config.js Resolved
@Andarist

Andarist commented Oct 5, 2024

Copy link
Copy Markdown
Member

I think even supporting odd versions shouldn't be a problem here and we kinda declare support for some of them anyway with that loose >=22.0.0. So I'd probably just keep it simple and use >=18.0.0 - I don't feel super strong about it though

@bluwy

bluwy commented Oct 5, 2024

Copy link
Copy Markdown
Member Author

I set it as >=18.0.0 for now and we could probably iterate it again as we go.

@bluwy

bluwy commented Oct 5, 2024

Copy link
Copy Markdown
Member Author

It looks like removing @babel/preset-env affected jest too, causing this CI fail, so I reverted it for now

@Andarist
Andarist merged commit 7f34a00 into next Oct 17, 2024
@Andarist
Andarist deleted the set-engines-field branch October 17, 2024 09:30
@github-actions github-actions Bot mentioned this pull request Oct 17, 2024
Merged
@Andarist Andarist mentioned this pull request May 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andarist Andarist Andarist left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bluwy @Andarist