Skip to content

Fix publish with yarn - #1449

Closed
bensampaio wants to merge 1 commit into
changesets:mainfrom
catawiki:fix-publish-with-yarn
Closed

Fix publish with yarn#1449
bensampaio wants to merge 1 commit into
changesets:mainfrom
catawiki:fix-publish-with-yarn

Conversation

@bensampaio

@bensampaio bensampaio commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown
  • Add support for yarn to getPublishTool.
  • Use yarn for publishing when it is the used package manager.

Fixes:

Screenshot 2024-08-30 at 15 28 48

@changeset-bot

changeset-bot Bot commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b0b9df3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci

codesandbox-ci Bot commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Bruno Nunes Sampaio
Fix publish with yarn
b0b9df3 
* Add support for yarn to `getPublishTool`.
* Use yarn for publishing when it is the used package manager.
@bensampaio
bensampaio force-pushed the fix-publish-with-yarn branch from 7d6f9c8 to b0b9df3 Compare August 30, 2024 13:59
@codecov

codecov Bot commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.91%. Comparing base (5150fc1) to head (b0b9df3).
⚠️ Report is 139 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/commands/publish/npm-utils.ts 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
- Coverage   81.02%   80.91%   -0.11%     
==========================================
  Files          54       54              
  Lines        2213     2216       +3     
  Branches      659      661       +2     
==========================================
  Hits         1793     1793              
- Misses        416      419       +3     
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Aug 30, 2024
Closed
Closed
@zouguangxian

zouguangxian commented Sep 22, 2024

Copy link
Copy Markdown

A PR has discussed this issue in detail #674

@bensampaio bensampaio mentioned this pull request Oct 1, 2024
Closed
1 task
@kvz

kvz commented Nov 13, 2024

Copy link
Copy Markdown

I guess this is superseded by #674, if so should this PR be closed?

Or if that one is sufficiently stuck, perhaps this one can be merged?

Would love to see yarn 4 support land in Changesets.

@rubencarvalho rubencarvalho mentioned this pull request Oct 22, 2025
Merged
@bluwy

bluwy commented Jul 27, 2026

Copy link
Copy Markdown
Member

Fixed in #2097

@bluwy bluwy closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bensampaio @zouguangxian @kvz @bluwy