Repository navigation
Refactor the test suite from external fixtures to inline ones - #1008
Merged
Merged
Conversation
|
Andarist
force-pushed
the
refactor-test-suite
branch
from
November 10, 2022 20:59
a5d387b to
29ba303
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 876e99e:
|
Andarist
force-pushed
the
refactor-test-suite
branch
from
November 13, 2022 09:48
1d684bf to
876e99e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having to declare fixtures (that more often than not consist of multiple dirs and files) was a real chore to me and I hesitated from adding new tests because of that. It's IMHO both easier to author and read/reason about the inline fixtures.