Repository navigation
Changes not detected by changeset cli 2.23.1 #869
Description
Affected Packages
@changesets/cli: 2.23.1
Problem
When running changeset in the cli after having made changes in a package, no changes are detected. That is, all packages are listed as unchanged.
When running the same command in version 2.22.0, the changes are detected and the package is suggested in the cli.
Config
{
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
"changelog": ["@changesets/changelog-github", { "repo": "PRIVATE_REPO" }],
"commit": false,
"fixed": [],
"linked": [],
"access": "restricted",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": []
}Proposed solution
Reacted by Jörundur Jörundsson, Brandon Slinkard, Saihajpreet Singh, Nicholas Haley, CCCAlanLiu, Dominik Mertz and Gyuwon Lee
Activity
slinkardbrandon commentedon Jul 13, 2022
I am having this same issue, its interesting because
changeset statusstill works, but the add command isn't detecting properly for some reason.glasser commentedon Jul 13, 2022
I'm seeing this too. Note that it's specifically 2.23.1 that causes the issue (2.23.0 is fine). Sees likely that #744 is to blame? Probably this line: https://github.com/changesets/changesets/pull/744/files#r920335959
Andarist commentedon Jul 13, 2022
I believe that has been fixed by https://github.com/changesets/changesets/releases/tag/%40changesets%2Fcli%402.23.2 .
BarryThePenguin commentedon Jul 21, 2022
I had the same problem, came here and found this issue, updated to 2.23.2 and it looks like that fixed the problem. Thanks! 🎉
Andarist commentedon Jul 21, 2022
This was a problem only briefly and got fixed in 2.23.2
buquan commentedon Feb 14, 2023
it appeared again at 2.26, need your reply, thanks
Andarist commentedon Feb 14, 2023
Please always try to share a repro case in a runnable form - either by providing a git repository to clone or a codesandbox. OSS maintainers usually can't afford the time to set up the repro, even if exact steps are given.
buquan commentedon Feb 14, 2023
ok i would create demo in codesandbox recently thanks alot
christopher-francisco commentedon Apr 18, 2023
@buquan we're seeing the same issue. Wondering if you were able to create the codesandbox?
rossipedia commentedon Jul 9, 2023
Hitting this also on
2.26.1, I'll see if I can provide a git repo that reproduces the issue. I believe it's related todevDependencies• Edit •
Ok this is solved: The packages I were expecting didn't have a
versionfield in thepackage.json. Adding thatversionfield letchangesetstart including it in the list of packages to select.It'd be nice if
changesetoffered a warning when it found a package without aversionfield, unless it was also listed in theignoreconfig option.