Skip to content

Minor version of peer package causes release of major version #524

Closed

Description

@danielkcz

Affected Packages

Here is the specific commit generated by changeset-release action.

mobxjs/mobx@c1f3019

Problem

As you can see, there is a single changeset with minor change to the two packages, mobx and mobx-react-lite. What's unexpected here is the major release of mobx-react-lite and mobx-react in cascade. Even in the changelog, it talks about minor/patch changes so it's rather confusing to the end user.

The mobx-react-lite depends on mobx, but only as peerDependency. In my opinion, it doesn't make much sense to force major in such a case. Minor versions are about adding something new, it's not breaking. What is the reasoning here?

Proposed solution

I think it should release a minor version of mobx-react-lite as requested.

We have fixed it manually for now.

Activity

  1. emmatown commented on Jan 28, 2021

    @emmatown
    Member

    This is currently expected behavior. You can change the behavior of Changesets to what you're probably expecting by adding this to your config:

    "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
        "onlyUpdatePeerDependentsWhenOutOfRange": true
    }

    See #185 and #383 for more details

  2. danielkcz commented on Jan 29, 2021

    @danielkcz
    Author

    Thank you, I've applied configuration and hopefully, it will have the desired effect.

  3. added a commit that references this issue on Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions