You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Minor version of peer package causes release of major version #524
As you can see, there is a single changeset with minor change to the two packages, mobx and mobx-react-lite. What's unexpected here is the major release of mobx-react-lite and mobx-react in cascade. Even in the changelog, it talks about minor/patch changes so it's rather confusing to the end user.
The mobx-react-lite depends on mobx, but only as peerDependency. In my opinion, it doesn't make much sense to force major in such a case. Minor versions are about adding something new, it's not breaking. What is the reasoning here?
Proposed solution
I think it should release a minor version of mobx-react-lite as requested.
We have fixed it manually for now.
Reacted by Tommy D. Rossi, emewjin, Luo Huidong and Kyle Awayan
Activity
emmatown commentedon Jan 28, 2021
This is currently expected behavior. You can change the behavior of Changesets to what you're probably expecting by adding this to your config:
See #185 and #383 for more details
Apply changeset exp. flag for handling peer deps
danielkcz commentedon Jan 29, 2021
Thank you, I've applied configuration and hopefully, it will have the desired effect.
Bump peer dependencies also when they're in range.
Bump peer dependencies also when they're in range. (#522)
Bump peer dependencies also when they're in range. (#522)
Bump peer dependencies also when they're in range. (#522)
Fix peer deps force bumping during releases (#422)
change changeset behavior
Bump peer dependencies also when they're in range. (#522)