Skip to content

Commit cef173a

Browse files
committed
small tweaks
1 parent e7d39e8 commit cef173a

7 files changed

Lines changed: 14 additions & 10 deletions

File tree

‎.changeset/stale-melons-shout.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
"@changesets/get-dependents-graph": patch
55
---
66

7-
Add support for workspace:^ and workspace:~
7+
Add support for `workspace:^` and `workspace:~` dependency ranges.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"name": "pkg-c",
3-
"version": "1.0.0-alpha.1"
3+
"version": "1.0.0"
44
}

‎packages/apply-release-plan/src/version-package.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@ export default function versionPackage(
5959
continue;
6060
const usesWorkspaceRange = depCurrentVersion.startsWith("workspace:");
6161
if (usesWorkspaceRange) {
62-
const workspaceDepVersion = depCurrentVersion.substr(10);
62+
const workspaceDepVersion = depCurrentVersion.replace(
63+
/^workspace:/,
64+
""
65+
);
6366
depCurrentVersion =
6467
workspaceDepVersion === "^" || workspaceDepVersion === "~"
6568
? "*"

‎packages/assemble-release-plan/src/index.test.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,14 @@ describe("assemble-release-plan", () => {
139139
);
140140

141141
expect(releases.length).toEqual(3);
142+
142143
expect(releases[0].name).toEqual("pkg-a");
143144
expect(releases[0].newVersion).toEqual("2.0.0");
145+
144146
expect(releases[1].name).toEqual("pkg-b");
145147
expect(releases[1].newVersion).toEqual("1.0.1");
146148
expect(releases[1].changesets).toEqual([]);
149+
147150
expect(releases[2].name).toEqual("pkg-c");
148151
expect(releases[2].newVersion).toEqual("1.0.1");
149152
expect(releases[2].changesets).toEqual([]);

‎packages/cli/src/commands/version/version.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ describe("workspace range", () => {
391391
},
392392
{
393393
name: "pkg-c",
394-
version: "1.0.0-alpha.1"
394+
version: "1.0.0"
395395
}
396396
]);
397397
});
@@ -1289,7 +1289,7 @@ describe("pre", () => {
12891289
},
12901290
{
12911291
name: "pkg-c",
1292-
version: "1.0.0-alpha.2"
1292+
version: "1.0.1-alpha.0"
12931293
}
12941294
]);
12951295
});

‎packages/get-dependents-graph/src/get-dependency-graph.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,10 @@ export default function getDependencyGraph(
7070
if (!match) continue;
7171

7272
const expected = match.packageJson.version;
73-
const isWorkspaceProtocol = depVersion.startsWith("workspace:");
73+
const usesWorkspaceRange = depVersion.startsWith("workspace:");
7474

75-
if (isWorkspaceProtocol) {
76-
depVersion = depVersion.substr(10);
75+
if (usesWorkspaceRange) {
76+
depVersion = depVersion.replace(/^workspace:/, "");
7777

7878
if (depVersion === "*" || depVersion === "^" || depVersion === "~") {
7979
dependencies.push(depName);

‎packages/git/src/index.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ async function getAllTags(cwd: string): Promise<Set<string>> {
3838
.trim()
3939
.split("\n");
4040

41-
console.log("gonna return set", new Set(tags));
42-
4341
return new Set(tags);
4442
}
4543

0 commit comments

Comments
 (0)