Repository navigation
Commit a74e783
perf: Stamp SQL and Snowflake registry protos with a content-hash version_id
SqlRegistry.proto() and SnowflakeRegistry.proto() never set version_id, so the
version-keyed caches fell back to object identity and every cache refresh
still rebuilt every object from proto. Set version_id to the sha1 of the
deterministic serialization, which is stable across refreshes and changes on
any apply or delete. On a 421 KB registry proto the hash costs 0.2 ms.
Refs feast-dev#7072
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Signed-off-by: Chandler King <[email protected]>1 parent 7deb605 commit a74e783
3 files changed
Lines changed: 40 additions & 0 deletions
File tree
- sdk/python
- feast/infra/registry
- tests/unit/infra/registry
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
1367 | 1368 | | |
1368 | 1369 | | |
1369 | 1370 | | |
| 1371 | + | |
1370 | 1372 | | |
1371 | 1373 | | |
1372 | 1374 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
1570 | 1571 | | |
1571 | 1572 | | |
1572 | 1573 | | |
| 1574 | + | |
1573 | 1575 | | |
1574 | 1576 | | |
1575 | 1577 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
731 | 731 | | |
732 | 732 | | |
733 | 733 | | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
0 commit comments