Don't normalize the input string#28
Merged
Qix- merged 2 commits intochalk:masterfrom Sep 19, 2019
kevva:remove-normalization
Merged
Don't normalize the input string#28Qix- merged 2 commits intochalk:masterfrom kevva:remove-normalization
Qix- merged 2 commits intochalk:masterfrom
kevva:remove-normalization
Conversation
While nifty, and visually it doesn't have an impact. However, when comparing a normalized string to a normal they can differ even though they look the same on the surface. Also, it's not needed for this module to function correctly.
|
I dont think the test is necessary. It's not required but not not allowed ;) |
Contributor
Author
|
@Qix-, agree :). |
|
Thanks! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While nifty, and visually it doesn't have an impact. However, when comparing a normalized string to a normal they can differ even though they look the same on the surface. Also, it's not needed for this module to function correctly.
See #27 (comment) for more details.