add jenkins support for .wasm files #62
Conversation
|
Hi @MikeHolman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
@dilijev, can you please review? |
|
After talking with @dilijev I will include this in same PR on top of rest of wasm changes. |
There was a problem hiding this comment.
While you're here, you might change the grep -v -E "..." pattern to match what's in the other file.
Namely, change this line to
git diff --name-only `git merge-base origin/master HEAD` HEAD |
grep -v -E 'test/.*\\.js$' |
grep -v -E '\\.cmd$' |
grep -v -E '\\.wasm$' |
grep -v -E '\\.baseline$' |
xargs -I % ./jenkins.check_file_eol.sh %
That will make it easier to make future changes to this list.
There was a problem hiding this comment.
Sure, that definitely is easier to mentally parse.
|
@MikeHolman I made some comments here. When you integrate this commit with your new PR, can you make these changes as well? Thanks. |
3 participants
add jenkins support for .wasm files. Note, that this is the binary format for WebAssembly, and we have a couple of these files in the wasm branch. This is causing test failures in #60