check for string true rather than existence in setup-python-keyring#41
Merged
imjasonh merged 1 commit intochainguard-dev:mainfrom Dec 8, 2025
Merged
Conversation
Contributor
|
Thank you for reporting this, and for sending a fix! I have to ask, are you using setup-chainctl from |
Contributor
Author
We were, yeah, although we now have it pinned to the most recent release. I think it was accidental on our part that we were picking up And thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw builds breaking because
python -m pip install "keyrings-chainguard-libraries"was executing on custom runners which don't have thepythonexecutable installed. The intent seems to be that this step only runs whensetup-python-keyringis overriden totrue, and not by default, but the current implementation will always run it (theifstatement as currently written evaluates totruebecause the variable exists). This fixes theifstatement to only evaluate totrueifsetup-python-keyringhas been overridden totrue.