support windows, add basic test on {linux,macos,windows}#4
Merged
imjasonh merged 5 commits intochainguard-dev:mainfrom Jun 10, 2024
Merged
support windows, add basic test on {linux,macos,windows}#4imjasonh merged 5 commits intochainguard-dev:mainfrom
imjasonh merged 5 commits intochainguard-dev:mainfrom
Conversation
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
imjasonh
changed the title
imjasonh
commented
Jun 10, 2024
| fi | ||
| echo "Downloading chainctl from ${url}" | ||
|
|
||
| curl -o ./chainctl -fsL "${url}" |
Contributor
Author
There was a problem hiding this comment.
Windows runners don't seem to have wget, but they have curl.
imjasonh
commented
Jun 10, 2024
| mv ./chainctl "${CHAINCTL_INSTALL_PATH}" | ||
| # Ensure install directory is on the PATH for future steps | ||
| echo "${CHAINCTL_INSTALL_PATH}" >> "${GITHUB_PATH}" | ||
| install -D --mode 0555 ./chainctl --target-directory "${CHAINCTL_INSTALL_PATH}" |
Contributor
Author
There was a problem hiding this comment.
Windows (and possibly macOS) runners don't have install, but it's just chmod && mv anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.