Skip to content

fix: export HTTP_AUTH to github env#17

Merged
89luca89 merged 3 commits intomainfrom
fix/export_http_auth
Nov 13, 2024
Merged

fix: export HTTP_AUTH to github env#17
89luca89 merged 3 commits intomainfrom
fix/export_http_auth

Conversation

@89luca89
Copy link
Contributor

it's useful for some situations where we need auth for packages or whatnot

@k4leung4
Copy link
Contributor

it's useful for some situations where we need auth for packages or whatnot

can you make this configurable, as some user may not want to have it exported?

@89luca89
Copy link
Contributor Author

it's useful for some situations where we need auth for packages or whatnot

can you make this configurable, as some user may not want to have it exported?

Done as requested 🫡

Copy link
Contributor

@k4leung4 k4leung4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@89luca89 89luca89 requested a review from k4leung4 November 13, 2024 17:29
@89luca89
Copy link
Contributor Author

Thanks!

@89luca89 89luca89 merged commit 8d93dcb into main Nov 13, 2024
@89luca89 89luca89 deleted the fix/export_http_auth branch November 13, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants