Conversation
Bazel 6 is removed from the CI matrix and from the supported-versions docs, raising the minimum supported Bazel to 7.6.1. With that minimum, two follow-ups become possible: - Fix #342: the apko module extension now sets extension_metadata(reproducible = True) unconditionally, replacing the always-False `hasattr(module_ctx, "bazel_version")` guard. This keeps the extension's generated repos out of consumers' MODULE.bazel.lock, as originally intended by #313/#137. reproducible= has been available since Bazel 7.1. - Remove the pre-7.1 range-request workaround. rctx.download now always sends a native Range header, so the URL-rewriting fallback, the initial-setup credential-helper machinery (apko_bazelrc, range.sh, .apko/.bazelrc, the initial-setup check and docs) are all dead code and are deleted. Verified: `bazel test //...` passes at the root (incl. the stardoc diff test) and the e2e/smoke WORKSPACE flow fetches apks via native Range headers with no credential helper. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
zmarano
approved these changes
Jul 1, 2026
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes Bazel 6 from the supported set and, now that the minimum Bazel is 7.6.1, fixes #342 and removes the pre-7.1 range-request workaround.
Drop Bazel 6 from CI & docs — removed the
6.5.0entry, itsexcludeblock, and the bazel-6 workaround step from the CI matrix; updatedREADME.mdand removed the Bazel-6 framing from the docs. Minimum supported Bazel is now 7.6.1.Fix apko extension reproducible=True gate never fires — hasattr(module_ctx, "bazel_version") is always False #342 — reproducible extension metadata — the apko module extension now sets
extension_metadata(reproducible = True)unconditionally, replacing the always-Falsehasattr(module_ctx, "bazel_version")guard (module_ctxhas nobazel_versionmember). This keeps the extension's generated repos out of consumers'MODULE.bazel.lock, as originally intended by feat: mark apko module extension as reproducible to reduce lockfile size #313 / Mark theapkomodule extension as reproducible to reduce bzlmod lockfile size and churn #137.reproducible=has been available since Bazel 7.1.Remove the pre-7.1 range-request workaround —
rctx.downloadnow always sends a nativeRangeheader. The URL-rewriting fallback (_range), the_check_initial_setupprobe, and the entire initial-setup credential-helper machinery (apko_bazelrc,range.sh,.apko/.bazelrc,docs/initial-setup.md) are dead code for supported Bazel versions and are deleted. Regenerateddocs/rules.mdaccordingly.Test plan
bazel test //...at the root passes (6/6), including the stardoc diff test confirmingdocs/rules.mdis in sync, and theexamples/lock/wolfi-basetests that perform real apk range-fetches.e2e/smokeWORKSPACE flow passes (3/3), fetching musl/busybox via nativeRangeheaders with no credential helper.Closes #342
🤖 Generated with Claude Code