fix(otel-export): remove redundant forceFlush before shutdown#753
Merged
joshrwolf merged 1 commit intochainguard-dev:mainfrom Feb 17, 2026
Merged
fix(otel-export): remove redundant forceFlush before shutdown#753joshrwolf merged 1 commit intochainguard-dev:mainfrom
joshrwolf merged 1 commit intochainguard-dev:mainfrom
Conversation
cpanato
approved these changes
Feb 17, 2026
…ent duplicate metric writes Signed-off-by: Josh Wolf <[email protected]>
joshrwolf
force-pushed
the
prevent-duplicate
branch
from
d62b386 to
b7555f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this prevents firing two exports of the same data. it turns out
MeterProvider.shutdown()internally callsonForceFlush(), so we don't need an explicitforceFlush().also it looks like the JS libraries only include a
PeriodicExportingMetricReader, so to prevent firing twice (one for the shutdown, one for the period), we just set a really long period.