feat: add signing with own key for melange-build#745
Merged
cpanato merged 1 commit intochainguard-dev:mainfrom Feb 23, 2026
Merged
feat: add signing with own key for melange-build#745cpanato merged 1 commit intochainguard-dev:mainfrom
cpanato merged 1 commit intochainguard-dev:mainfrom
Conversation
Member
|
can you please rebase? |
eminaktas
force-pushed
the
feat/sign-own-key
branch
5 times, most recently
from
d86a2aa to
e9250d1
Compare
Signed-off-by: Emin Aktas <[email protected]>
eminaktas
force-pushed
the
feat/sign-own-key
branch
from
e9250d1 to
4041e3a
Compare
Contributor
Author
@cpanato done. Thanks for the reveiw. |
cpanato
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables users to sign packages using their own key, which is not supported in the current implementation.
At the moment, it always generates a temporary key, even when that behavior is explicitly disabled. This PR introduces proper support for providing and using a custom key, and clarifies the signing logic.
Updated behavior
The signing flow now works as follows:
If
sign-with-own-keyis set totrue, the package will be signed using the key at the provided path.If
sign-with-temporary-keyis set totrue, a temporary key pair will be generated and used to sign the package.If both
sign-with-own-keyandsign-with-temporary-keyare set totrue, the temporary key takes precedence and will be used for signing.This ensures users can explicitly choose between using their own key or a generated temporary key, with a clear and predictable priority when both options are enabled.