feat: setPathValue returns the object in which the value was set. Closes #6#44
Merged
keithamus merged 1 commit intochaijs:masterfrom Oct 11, 2016
lucasfcosta:return-obj-from-set
Merged
feat: setPathValue returns the object in which the value was set. Closes #6#44keithamus merged 1 commit intochaijs:masterfrom lucasfcosta:return-obj-from-set
keithamus merged 1 commit intochaijs:masterfrom
lucasfcosta:return-obj-from-set
Conversation
Contributor
|
LGTM, very clean change. Nice job, @lucasfcosta 👍 |
Contributor
|
LGTM |
Contributor
|
Wait it might be good to add a small note about this behavior in the docs so it doesn't go unnoticed and unused. |
Member
|
FYI @shvaikalesh you're not in the MAINTAINERS file, so your LGTM didn't count. Feel free to raise a PR adding your name for this and any other project you'd like to be a part of 😄 |
Member
|
(This is also a LGTM from me 😆) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to solve #6.
I'm just returning the whole object in which we've set the value.
I also added tests for that.