Skip to content

fix: support inspecting bigints (#1321)#1365

Closed
vapier wants to merge 1 commit intochaijs:masterfrom
vapier:master
Closed

fix: support inspecting bigints (#1321)#1365
vapier wants to merge 1 commit intochaijs:masterfrom
vapier:master

Conversation

@vapier
Copy link
Copy Markdown
Contributor

@vapier vapier commented Oct 19, 2020

No description provided.

@vapier vapier requested a review from a team as a code owner October 19, 2020 02:42
@vapier
Copy link
Copy Markdown
Contributor Author

vapier commented Oct 19, 2020

running npm test seems to have regenerated chai.js with changes before mine. not sure if i should include them all here.

@keithamus
Copy link
Copy Markdown
Member

This looks like a great change, but we're working on integrating loupe into Chai 4.4.0 which will handle this behaviour.

I'm going to close this PR as it'll only be overwritten when we integrate loupe. We really value your contribution here though - and it would be amazing if you could add some tests to loupe to verify BigInt works! Would you be able to do that please?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants