Skip to content

ci: add CI/CD security analysis workflow - #2587

Merged
AlexV525 merged 5 commits into
cfug:mainfrom
AmosHuKe:feat-ci-security-analysis
Aug 7, 2026
Merged

AlexV525 merged 5 commits into
cfug:mainfrom
AmosHuKe:feat-ci-security-analysis

Conversation

@AmosHuKe

@AmosHuKe AmosHuKe commented Aug 6, 2026 •

Copy link
Copy Markdown
Member
  • Added new CI workflow for CI/CD security analysis (cicd_security_analysis.yml).
  • Replaced dangerous workflow_run with workflow_call to prevent potential arbitrary code execution, credential theft, or privilege escalation in the target repository context.
    Minimized permissions for coverage_comment.yml.
  • Replaced third-party comment action with the official actions/github-script to reduce supply-chain attacks.
  • Fixed other minor permission and syntax.

Warning

The coverage_comment.yml workflow has not yet been tested.
If it fails during execution, additional fixes will be required in a follow-up PR.

New Pull Request Checklist

  • I have read the Documentation
  • I have read the Agent Contribution Guidelines (required if any part of the change was produced with AI assistance)
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AmosHuKe

This comment was marked as outdated.

@AmosHuKe
AmosHuKe marked this pull request as ready for review August 6, 2026 12:18
@AmosHuKe
AmosHuKe requested a review from a team as a code owner August 6, 2026 12:18
@AmosHuKe
AmosHuKe marked this pull request as draft August 6, 2026 12:34
@AmosHuKe
AmosHuKe marked this pull request as ready for review August 6, 2026 13:37
@AlexV525
AlexV525 requested a lite review from Copilot August 7, 2026 03:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the repository’s GitHub Actions setup by introducing a CI/CD security analysis workflow (zizmor) and tightening workflow permissions/action usage to reduce risk from over-privileged tokens and third-party dependencies.

Changes:

  • Adds a scheduled/on-change CI/CD workflow security scan using zizmor.
  • Sets workflow-level permissions: {} across multiple workflows and updates action usage (pinned SHAs, persist-credentials: false).
  • Replaces the third-party sticky PR comment action with actions/github-script for coverage commenting.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/workflows/tests.yml Disables default permissions, updates action pins/config, and tweaks coverage artifact handling.
.github/workflows/publish.yml Adds concurrency and disables default permissions; keeps publish job permissions scoped.
.github/workflows/coverage_comment.yml Disables default permissions and rewrites coverage PR commenting using actions/github-script.
.github/workflows/coverage_base.yml Adds concurrency and disables default permissions; updates action pins.
.github/workflows/codeql.yml Adds concurrency and disables default permissions; updates CodeQL action pins and checkout settings.
.github/workflows/cicd_security_analysis.yml New workflow to scan .github/ for CI/CD security issues using zizmor.
.github/workflows/check_issues_access.yml Adds concurrency and disables default permissions; job re-enables minimal needed permissions.
.github/dependabot.yaml Adds Dependabot cooldown to delay very new GitHub Actions updates.
.github/config/cicd_security_analysis_zizmor_config.yaml Adds zizmor configuration and rule toggles/ignores for CI scanning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/tests.yml Resolved
Comment thread .github/workflows/coverage_base.yml Resolved
Comment thread .github/workflows/coverage_comment.yml Resolved
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 86.19% 🟢 86.19% ⚪ 0%

Minimum allowed coverage is 0%, this run produced 86.19%

@AlexV525
AlexV525 merged commit 6ad2f90 into cfug:main Aug 7, 2026
6 checks passed
@AmosHuKe
AmosHuKe deleted the feat-ci-security-analysis branch August 7, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants