Skip to content

Add the CHANGELOG requirement in the PR template - #1679

Merged
AlexV525 merged 1 commit into
mainfrom
pr-template-changelog
Feb 20, 2023
Merged

AlexV525 merged 1 commit into
mainfrom
pr-template-changelog

Conversation

@AlexV525

Copy link
Copy Markdown
Member

The comment would be an example. Related to #1662. This would be a temporary solution until we can have a robust check.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@AlexV525
AlexV525 requested a review from a team as a code owner February 20, 2023 12:56
@AlexV525
AlexV525 merged commit 9909245 into main Feb 20, 2023
@AlexV525
AlexV525 deleted the pr-template-changelog branch February 20, 2023 13:08
wilinz pushed a commit to wilinz/dio that referenced this pull request Aug 31, 2026
The comment would be an example. Related to cfug#1662. This would be a
temporary solution until we can have a robust check.

### New Pull Request Checklist

- [ ] I have read the
[Documentation](https://pub.dev/documentation/dio/latest/)
- [ ] I have searched for a similar pull request in the
[project](https://github.com/cfug/dio/pulls) and found none
- [ ] I have updated this branch with the latest `main` branch to avoid
conflicts (via merge from master or rebase)
- [ ] I have added the required tests to prove the fix/feature I'm
adding
- [ ] I have updated the documentation (if necessary)
- [ ] I have run the tests without failures
- [ ] I have updated the `CHANGELOG.md` in the corresponding package

### Additional context and info (if any)

<!-- Provide more context and info about the PR. -->

Signed-off-by: Alex Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants