Added more tags and attributes to check in VarScoper#495
Added more tags and attributes to check in VarScoper#495ryaneberly merged 2 commits intocflint:devfrom KamasamaK:dev
Conversation
|
Code looks good. Got a couple failing tests to reconcile: |
|
Instead of having those values in |
|
@KamasamaK , Yes that is what CFMLTagInfo.isAssignmentAttribute is for. Though it isn't currently in use and would take some testing. The three failing tests: TestCFBugs_VarScoper_Names.java TestCFBugs_VarScoper_TagAttr.java cfloop_index_413.cfc |
|
I had changed the first 2 locally already as it looked easy enough. I was trying to figure out how that integration test was even finding Regarding the column, yes it does look like the column is more correct now, so however it found it before must not be reporting that correctly. If we take column to be number of characters, then 33 is correct. It would only be 37 if the tab counted as 4 columns. Although the other one in that file for Anyway, the tests are fixed now. |
|
Thanks @KamasamaK |
No description provided.