Merged
Conversation
Collaborator
Author
|
As the unit tests passed, I'm going to go ahead and merge this. Couple things to note:
|
Contributor
|
Thanks Denny
…On Wed, Sep 13, 2017 at 2:04 AM, Denny Valliant ***@***.***> wrote:
Merged #466 <#466>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#466 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AFtZu5wT0hLVyNhUC9hFySSgAndBhV1pks5sh3BtgaJpZM4PVnNw>
.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out it's really useful to have the offset (position in the document if it were a stream of chars) of a bug. Required, in fact, for some applications to figure out where in a document something is.
We can figure this out via line/col by having things keep tables of line/offset positions, but generally they'd need the source input to build this table, and thus another hit on the file system and whatnot (which is rough with lots of files).
The parser already has this info, so we should expose it and save any tools that use offsets versus line+column the trouble of converting the location info. This also adds a
lengthattribute, which is a little hokey but seems to work fine (used to visually highlight the code causing the issue).