Merged
Conversation
Contributor
Author
|
Ah ignore that I need to update the tests |
Contributor
Author
|
OK all good to review now thanks! |
Contributor
|
I like it. Looks good. It may break the CFLint Jenkins plugin, but we'll address it if we need to. This is the right direction. |
Contributor
Author
|
I can test with the CFLint Jenkins plugin before merging |
Contributor
|
I haven't touched the plugin for a long time, actually now that I think
about it -- it just works off the output. Your change should be fine.
…On Fri, Aug 11, 2017 at 11:05 PM, Justin Mclean ***@***.***> wrote:
I can test with the CFLint Jenkins plugin before merging
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#441 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFtZu-YO7nkA9cIOrggpmTuyX8mIN5fVks5sXRaUgaJpZM4O1RHp>
.
|
Collaborator
|
@ryaneberly Yes, pretty sure the plugin is driven by the output xml. That being said, my changes to that might have broken the plugin anyway already. And 1.3/2.0 might break it again and more :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed the level array into an enum someone mind reviewing? Thanks.