Skip to content

Introducing a CF domain variable#302

Merged
dblodgett-usgs merged 53 commits intocf-convention:masterfrom
davidhassell:domain
Nov 23, 2020
Merged

Introducing a CF domain variable#302
dblodgett-usgs merged 53 commits intocf-convention:masterfrom
davidhassell:domain

Conversation

@davidhassell
Copy link
Copy Markdown
Contributor

@davidhassell davidhassell commented Sep 22, 2020

See issue #301 for discussion of these changes.

Release checklist

  • Authors updated in cf-conventions.adoc?
  • Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • history.adoc up to date?
  • Conformance document up-to-date?

For maintainers

After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then master always is a draft for the next version.

ch05.adoc Outdated
order in which the dimensions appear in the **`dimensions`** attribute
string. The presence of a **`dimensions`** attribute will identify the
variable as a domain variable. If a domain has no dimensions then the
value of the **`dimensions`** attribute must be an empty string.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a domain exist without any dimensions?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can - just provide the dimensions with a an empty string (domain:dimensions = "" ;). It still needs the dimensions attribute so that it is recognisable as a domain variable.

Such a domain can still have scalar coordinate variables, grid mappings, etc. I mentioned that it is allowed in the conformance requirements, but I agree that it should be mentioned explicitly in the new 5.8 text. I'll propose some new words in this thread, shortly ...

Copy link
Copy Markdown
Contributor Author

@davidhassell davidhassell Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I should have read the existing text first rather than replying from memory - sorry I restated a lot of uncontested stuff. I'll try again)

A domain can certainly exist without explicit dimensions, as they may be implied by scalar coordinate variables.

    char domain ;
        domain:dimensions = "" ;
        domain:cooridnates = "time" ;
    double time ;
        time:units = "days since 2000-01-01" ;

Would this next one be a valid domain, though?

    char domain ;
        domain:dimensions = "" ;
        domain:grid_mapping = "lambert_conformal" ;

My gut feeling is "yes" ....

@erget erget linked an issue Sep 24, 2020 that may be closed by this pull request
@dblodgett-usgs
Copy link
Copy Markdown
Contributor

If no further discussion takes place in #301, we will merge this pull request on Monday November 23rd.

Copy link
Copy Markdown
Contributor

@JonathanGregory JonathanGregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content is fine, thanks, but I would note two minor problems in wording:

  • "blank separated list of the dimensions names" should be dimension or dimensions'

  • In "Multiple domain variables may exist in a file with, or without, other data variables" I think "other" should be deleted, because domain variables are not data variables.

Jonathan

@dblodgett-usgs
Copy link
Copy Markdown
Contributor

@davidhassell -- please update the history then we can go ahead and merge IMHO.

@davidhassell
Copy link
Copy Markdown
Contributor Author

Thanks, @dblodgett-usgs. History is updated.

@dblodgett-usgs dblodgett-usgs merged commit 00aa9c3 into cf-convention:master Nov 23, 2020
@davidhassell davidhassell added this to the 1.9 milestone Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introducing a CF domain variable

4 participants