You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0ef3f4b
Browse filesBrowse the repository at this point in the historyBrowse files
fix(deps): pin go_router 18.1.1 for shell route pushes
With go_router 18.1.0, pushing a shell route over a root route that was itself pushed over the shell, such as push('/forbidden') and then push('/settings'), gave both shell pages the same page key and failed the Navigator assertion '!keyReservation.contains(key)' (flutter/flutter#140586).
go_router 18.1.1 scopes the keys of the second shell page. A widget test drives that push through the app's router and fails on 18.1.0.
18.1.1 also stops wrapping unrelated async errors from redirects as GoException; the app's redirect is synchronous and never throws, so nothing else changes. The upgrade guide and README name the new version.
|`sentry_flutter`| 9.22.0 | 10.1.0 | major; Android minSdk 26, Apple builds use SwiftPM only, see 5.3 |
71
71
|`flutter_secure_storage`| 10.3.1 | 11.2.0 | major; no code change, see 5.4 |
72
72
|`equatable`| 2.0.8 | 3.0.0 | major; no code change |
@@ -125,6 +125,8 @@ The fix keeps the 17.x behavior:
125
125
126
126
The only remaining difference is that go_router's internal `HeroController` uses a straight tween instead of the Material arc; the app has no `Hero` widgets.
127
127
go_router 18.0.2 also wraps shell navigators in `Semantics(container: true)`, so the sidebar and top bar are now in the semantics tree on desktop.
128
+
go_router 18.1.0 failed the Navigator assertion `'!keyReservation.contains(key)'` when a shell route was pushed over a root route that was itself pushed over the shell, for example `push('/forbidden')` and then `push('/settings')`, because both shell pages got the same page key (flutter/flutter#140586).
129
+
18.1.1 gives the second shell page its own keys, and `app_router_pages_test.dart` covers that push.
0 commit comments