Conversation
Added python_requires to specify the required python version for the library.
|
I believe this library supports Python 3.5+ not 3.3+ |
Ok updated it. There are classifiers for python 3.3 and 3.4 that's why I thought it would be 3.3+ |
|
Should I also remove the classifiers for python 3.3 and 3.4? |
IMO, yes. The classifiers and |
iceman201
left a comment
iceman201
left a comment
There was a problem hiding this comment.
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
would be good to remove
| include_package_data=True, | ||
| zip_safe=False, | ||
| license='MPL-2.0', | ||
| python_requires=">=3.5", |
There was a problem hiding this comment.
Would be preferable to introduce this in declarative config. i.e.:
# setup.cfg
[options]
python_requires = >=3.5
There was a problem hiding this comment.
Would be good to do setup-py-upgrade in another pr I think?
There was a problem hiding this comment.
Yes, perhaps. My preference is to introduce changes in the preferred location rather than to cling to old conventions, but I also see the value in keeping it all consistent and to move everything at once.
|
This PR fixes #174. |
8 participants
Added python_requires to specify the required python version for the library.