Command-line UX overhaul #8852
Merged
Command-line UX overhaul #8852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add "Successfully deployed ..." message using display_util - Remove IReporter usage and replace with display_util - Standardize "... could not find a VirtualHost ..." error This changes also bumps the version of certbot required by certbot-nginx and certbot-apache to take use of the new display_util function.
since the http plugins now require IDisplay, we need to inject it
because certbot 1.10.0 depends on acme>=1.8.0, we need to use acme==1.8.0 in the -oldest tests
Changes the output of run, certonly and certonly --csr. No longer uses IReporter.
--dns-blah won't work for third-party plugins, they need to be specified using --authenticator dns-blah.
Prevents Certbot from superfluously invoking the installer restart during dry-run renewals. (This does not affect authenticator restarts). Additionally removes some CLI output that was reporting the fullchain path of the renewed certificate.
- Display a message when certificate installation begins. - Don't use IReporter, just log errors immediately if restart/rollback fails. - Prompt the user with a command to retry the installation process once they have fixed any underlying problems.
and move expiry date to be above the renewal advice
Co-authored-by: ohemorange <[email protected]>
Co-authored-by: ohemorange <[email protected]>
Co-authored-by: ohemorange <[email protected]>
alexzorin
approved these changes
May 25, 2021
This was referenced May 25, 2021
This was referenced May 25, 2021
bmw
pushed a commit
that referenced
this pull request
May 25, 2021
1.10.0 was a bad release and this breaks our oldest Boulder tests. I bumped the version to 1.10.0 in #8852 to get access to a new public display_util API, but that was the release with the broken deprecation of `--manual-public-ip-logging-ok`. So let's bump it to 1.10.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8560.
This PR is a combination of the branches mentioned in #8560, along with any minor fixes we noticed during the merging process.