Repository navigation
deprecate make_self_signed_cert - #10466
Conversation
| # 1) Our own warning about the deprecated acme.crypto_util.make_self_signed_cert function. | ||
| filterwarnings = | ||
| error | ||
| ignore:make_self_signed_cert is deprecated:DeprecationWarning |
There was a problem hiding this comment.
a little tempted to suggest just removing GenMakeSelfSignedCertTest now and not needing this warning since we're not using it anymore, but I'm fine with leaving it now and removing it along with the code later, as well.
There was a problem hiding this comment.
how about my most recent commit?
it fixes up tests to actually test for the warning and allows us to not ignore the warning globally so if we ever try to write a new call to make_self_signed_cert, we'll see the warning. it also lets us keep tests around until we actually remove the function. i personally think an approach like this is ideal whenever we deprecate functionality
if you don't like this for some reason tho, just lmk whatever approach you prefer and i'll implement that
ohemorange
left a comment
ohemorange
left a comment
There was a problem hiding this comment.
I like that even better, thanks!
with #10465, make_self_signed_cert is no longer used outside of our tests so let's move it there and remove it from our public API
it might be easiest to look at the first two commits here individually. the first one copies make_self_signed_cert to the compatibility tests with no changes. the second commit cleans it up and removes a lot of the additional functionality we no longer need