Merged
Conversation
zoracon
approved these changes
Nov 14, 2024
bmw
added a commit
that referenced
this pull request
Nov 14, 2024
fixes #9967 actually fixing the underlying issue is being tracked by #10053 in addition to the unit test, i tested this manually. if you obtain any cert and run `certbot renew` in an up-to-date dev environment, there's 3 warnings when on `main` and none on this branch (cherry picked from commit aa6ea3b)
ohemorange
pushed a commit
that referenced
this pull request
Nov 14, 2024
fixes #9967 actually fixing the underlying issue is being tracked by #10053 in addition to the unit test, i tested this manually. if you obtain any cert and run `certbot renew` in an up-to-date dev environment, there's 3 warnings when on `main` and none on this branch (cherry picked from commit aa6ea3b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9967
actually fixing the underlying issue is being tracked by #10053
in addition to the unit test, i tested this manually. if you obtain any cert and run
certbot renewin an up-to-date dev environment, there's 3 warnings when onmainand none on this branch