Add comment explaining change

SgtCoDFish · cert-manager-bot · commit 47828f2edb50 · 2025-02-12T12:32:25.000Z
Signed-off-by: Ashley Davis &lt;SgtCoDFish@users.noreply.github.com&gt;
diff --git a/pkg/issuer/acme/dns/cloudflare/cloudflare.go b/pkg/issuer/acme/dns/cloudflare/cloudflare.go
@@ -233,6 +233,9 @@ func (c *DNSProvider) findTxtRecord(ctx context.Context, fqdn, content string) (
 
 	for _, rec := range records {
 		if rec.Name == util.UnFqdn(fqdn) && rec.Content == content {
+			// Cloudflare made a breaking change to their API and removed the ZoneID from responses:
+			// https://developers.cloudflare.com/fundamentals/api/reference/deprecations/#2024-11-30
+			// The simplest fix is to set the ZoneID manually here
 			rec.ZoneID = zoneID
 			return &rec, nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -233,6 +233,9 @@ func (c *DNSProvider) findTxtRecord(ctx context.Context, fqdn, content string) (`
`233`	`233`
`234`	`234`	`for _, rec := range records {`
`235`	`235`	`if rec.Name == util.UnFqdn(fqdn) && rec.Content == content {`
	`236`	`+ // Cloudflare made a breaking change to their API and removed the ZoneID from responses:`
	`237`	`+ // https://developers.cloudflare.com/fundamentals/api/reference/deprecations/#2024-11-30`
	`238`	`+ // The simplest fix is to set the ZoneID manually here`
`236`	`239`	`rec.ZoneID = zoneID`
`237`	`240`	`return &rec, nil`
`238`	`241`	`}`