Merged
Conversation
14 tasks
mattbenjamin
force-pushed
the
wip-get-objattrs
branch
4 times, most recently
from
0a0a379 to
7e923f5
Compare
cbodley
reviewed
Jul 10, 2024
Contributor
cbodley
left a comment
cbodley
left a comment
There was a problem hiding this comment.
can i suggest some additional test coverage?
- non-multipart upload,
- current version,
- non-current version,
- delete marker?
- pagination of parts (ex MaxParts=1 PartNumberMarker=2),
- fields not requested by ObjectAttributes are not returned
are there any error paths that are worth testing for?
Contributor
and sse-c when we add it: test_encryption_sse_c_method_head is a good example for HeadObject |
Contributor
|
i pushed a branch with extra tests to linuxbox2/s3-tests@wip-get-objattrs...cbodley:s3-tests:wip-get-objattrs
i left review comments on ceph/ceph#55259 about the issues that uncovered, mainly around the pagination test |
mattbenjamin
force-pushed
the
wip-get-objattrs
branch
from
511894a to
7d12575
Compare
cbodley
force-pushed
the
wip-get-objattrs
branch
from
7d12575 to
9bf223d
Compare
Signed-off-by: Matt Benjamin <[email protected]>
there seem to be workloads which assume checksum algorithm can be omitted from upload-part Signed-off-by: Matt Benjamin <[email protected]>
* multipart upload without checksums * multipart upload with a single part * pagination of multipart parts * non-multipart upload with/without checksum * versioned object, current and non-current * sse-c encrypted object Signed-off-by: Casey Bodley <[email protected]> Signed-off-by: Matt Benjamin <[email protected]>
Signed-off-by: Matt Benjamin <[email protected]>
mattbenjamin
force-pushed
the
wip-get-objattrs
branch
from
2f041ae to
a30f6e0
Compare
adamemerson
approved these changes
Jan 13, 2025
Contributor
|
cherry-picked to ceph-master |
cbodley
pushed a commit
that referenced
this pull request
Jun 19, 2025
includes tests for CRC64NVME, tests for selecting COMPOSITE and FULL_OBJECT checksums a decomposed matrix of tests for all checksum types also removes the mixed checksum upload case that no longer works in recent boto3 cleanups, add sha1 checksum validation failure (mismatch) returns BadDigest multipart checksum matrix helper now validates checksum and checksum type for all operations which can return them (complete-multipart, head-object, and get-object-attributes) Signed-off-by: Matt Benjamin <[email protected]> (cherry picked from commit 2c9c5d9) Conflicts: s3tests_boto3/functional/test_s3.py GetObjectAttributes tests from #571 not backported
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.