remove reliance on x-rgw-object-count and x-rgw-bytes-used headers#517
Merged
soumyakoduri merged 1 commit intoceph:masterfrom Jul 3, 2023
Merged
Conversation
This was referenced Jun 21, 2023
alimaredia
approved these changes
Jun 21, 2023
Contributor
|
@cbodley this looks good to me. Can I merge this and then run the master branch on the dbstore and verify (with limit 1) rgw suites? |
Contributor
Author
|
@alimaredia tests are queued in https://pulpito.ceph.com/cbodley-2023-06-21_18:30:33-rgw-main-distro-default-smithi/, let's wait on that |
soumyakoduri
approved these changes
Jun 22, 2023
stop using head_bucket() to fetch these response headers, and use list_objects_v2() instead to count objects and sizes Fixes: ceph#315 Signed-off-by: Casey Bodley <[email protected]>
cbodley
force-pushed
the
wip-rm-rgw-stat-bucket-headers
branch
from
41daf29 to
188b392
Compare
Contributor
Author
|
some of these test cases failed in the rgw/dbstore suite, so i had to restore some of the |
Contributor
|
got it, when you post a clean run I'll go ahead and merge the PR |
Contributor
Author
Contributor
|
cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stop using
head_bucket()to fetch these response headers, and uselist_objects_v2()instead to count objects and sizes. this allows us to remove severalfails_on_awsandfails_on_dbstoremarkersFixes: #315