add multipart ranges to encryption tests#266
Merged
cbodley merged 3 commits intoceph:masterfrom Jun 14, 2023
Merged
Conversation
theanalyst
force-pushed
the
wip-38700-range
branch
from
3e2f4d6 to
df9af4f
Compare
This was referenced Mar 26, 2019
cbodley
reviewed
Apr 1, 2019
Contributor
cbodley
left a comment
cbodley
left a comment
There was a problem hiding this comment.
minor comment. otherwise ready now that the fix is merged
theanalyst
force-pushed
the
wip-38700-range
branch
from
df9af4f to
90c825e
Compare
cbodley
approved these changes
Apr 2, 2019
Contributor
|
@alimaredia this one is ready to merge - how would you like to coordinate this with the others prs in flight? |
Contributor
@mdw-at-linuxbox is working on a similar encryption bug for multisite in https://tracker.ceph.com/issues/46062, so i plan to rebase this and make sure they still pass |
This is to avoid a get_object call for every range check as the object size will not change during this duration and we'd most likely already know the object sizes beforehand Signed-off-by: Abhishek Lekshmanan <[email protected]>
Signed-off-by: Abhishek Lekshmanan <[email protected]>
Contributor
|
@alimaredia rebased tests still passing against ceph main 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.