Skip to content

mgr/dashboard: add telemetry notification regression tests - #72008

Merged
nizamial09 merged 1 commit into
ceph:mainfrom
AnuragRaut08:fix-telemetry-update-success-message
Oct 15, 2026
Merged

nizamial09 merged 1 commit into
ceph:mainfrom
AnuragRaut08:fix-telemetry-update-success-message

Conversation

@AnuragRaut08

@AnuragRaut08 AnuragRaut08 commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Fixes: https://tracker.ceph.com/issues/80794
Signed-off-by: Anurag Raut [email protected]

PR Description

When telemetry is already configured and activated, updating its configuration should not display the activation success notification. The functional fix is addressed in #70776.

This PR adds regression tests to verify that the Dashboard displays the correct success notification for both telemetry activation and updates to an existing configuration:

  • Initial activation displays the configured and activated success notification.
  • Updating an existing telemetry configuration displays an update-specific success notification.

Screencast:

Screencast.From.2026-08-03.13-25-42.webm

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-update-success-message branch from 397cf44 to 8773037 Compare September 23, 2026 18:25
@AnuragRaut08
AnuragRaut08 marked this pull request as ready for review September 23, 2026 18:40
@AnuragRaut08
AnuragRaut08 requested a review from a team as a code owner September 23, 2026 18:40
@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-update-success-message branch from 8773037 to 6b6a443 Compare September 24, 2026 05:21
@github-project-automation github-project-automation Bot moved this from New to Reviewer approved in Ceph-Dashboard Sep 24, 2026
@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-update-success-message branch from 6b6a443 to 3616fec Compare September 28, 2026 05:50
@nizamial09

Copy link
Copy Markdown
Member

@AnuragRaut08 please follow our commit guidelines when delivering changes btw. In this case prefix commits with mgr/dashboard: and include the tracker id in the commit message with maybe a brief message in the commit message if you think its relavant.

@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-update-success-message branch from 3616fec to 6f5475f Compare September 28, 2026 06:11
@github-actions

Copy link
Copy Markdown

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@AnuragRaut08

Copy link
Copy Markdown
Contributor Author

jenkins test dashboard

@AnuragRaut08

Copy link
Copy Markdown
Contributor Author

jenkins test dashboard cephadm

@github-actions

Copy link
Copy Markdown

This is an automated message by src/script/redmine-upkeep.py.

I found one or more Fixes: tags in the commit messages in

git log 48ace71eaf1bb39402974945bac25aef1f72ec42^..48ace71eaf1bb39402974945bac25aef1f72ec42

The referenced tickets are:

Those tickets do not reference this merged Pull Request. If this Pull Request merge resolves any of those tickets, please update the "Pull Request ID" field on each ticket. A future run of this script will appropriately update them.

Update Log: https://github.com/ceph/ceph/actions/runs/38686576792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants