Skip to content

mgr/dashboard: validate telemetry license agreement - #71928

Merged
nizamial09 merged 1 commit into
ceph:mainfrom
AnuragRaut08:fix-telemetry-agreement-validation
Sep 30, 2026
Merged

mgr/dashboard: validate telemetry license agreement#71928
nizamial09 merged 1 commit into
ceph:mainfrom
AnuragRaut08:fix-telemetry-agreement-validation

Conversation

@AnuragRaut08

@AnuragRaut08 AnuragRaut08 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Fixes: https://tracker.ceph.com/issues/80672
Signed-off-by: Anurag Raut [email protected]

PR Description:

This PR fixes an issue where the telemetry license agreement in the Ceph Dashboard was not properly validated when the agreement checkbox was left unchecked. The fix adds required-field validation and displays an appropriate error message, ensuring the agreement must be accepted before submitting telemetry configuration. Also adds regression tests to verify the validation behavior for both checked and unchecked states.

Screencast:

Screencast.From.2026-09-20.20-21-32.mp4

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@AnuragRaut08
AnuragRaut08 requested a review from a team as a code owner September 20, 2026 16:32
nizamial09
nizamial09 reviewed Sep 22, 2026
View reviewed changes

@nizamial09 nizamial09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to carbonize the telemetry form component. Probably in a separate PR since this is a bug fix.

Comment thread src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.html Resolved
@AnuragRaut08 AnuragRaut08 changed the title fix(dashboard): validate telemetry license agreement mgr/dashboard: validate telemetry license agreement Sep 22, 2026
@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-agreement-validation branch from 1fdf8bb to 78cac8d Compare September 24, 2026 05:57
@github-project-automation github-project-automation Bot moved this from New to Reviewer approved in Ceph-Dashboard Sep 24, 2026
@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-agreement-validation branch from 78cac8d to d9a40e5 Compare September 28, 2026 07:17
@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-agreement-validation branch from d9a40e5 to 399cf52 Compare September 29, 2026 04:47
@AnuragRaut08

AnuragRaut08 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

jenkins test make check

@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-agreement-validation branch from 399cf52 to 0479077 Compare September 29, 2026 09:26
@nizamial09

nizamial09 commented Sep 29, 2026

Copy link
Copy Markdown
Member

make checks failing on lint error btw.

[lint:html    ] Checking formatting...
[lint:html    ] All matched files use Prettier code style!
[lint:prettier] src/app/ceph/cluster/telemetry/telemetry.component.spec.ts
[lint:eslint  ] 
[lint:eslint  ] Linting "ceph-dashboard"...
[lint:eslint  ] 
[lint:eslint  ] All files pass linting.
[lint:eslint  ] 

Try running 'npm run fix' to fix some linting errors. Some errors might need a manual fix.

@AnuragRaut08
AnuragRaut08 force-pushed the fix-telemetry-agreement-validation branch from 0479077 to 40b1c53 Compare September 29, 2026 12:40
@nizamial09
nizamial09 merged commit 2c9ac2e into ceph:main Sep 30, 2026
15 of 16 checks passed
@AnuragRaut08 AnuragRaut08 mentioned this pull request Nov 5, 2026
Open
4 of 14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nizamial09 nizamial09 nizamial09 approved these changes
@abhidesai6 abhidesai6 Awaiting requested review from abhidesai6 abhidesai6 is a code owner automatically assigned from ceph/dashboard
@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14 aaSharma14 is a code owner automatically assigned from ceph/dashboard
@afreen23 afreen23 Awaiting requested review from afreen23

Assignees

No one assigned

Labels

dashboard pybind

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnuragRaut08 @nizamial09