Skip to content

mgr/dashboard: avoid re-enabling telemetry - #70776

Merged
afreen23 merged 1 commit into
ceph:mainfrom
AnuragRaut08:wip-fix-telemetry-multiple-activation
Aug 5, 2026
Merged

afreen23 merged 1 commit into
ceph:mainfrom
AnuragRaut08:wip-fix-telemetry-multiple-activation

Conversation

@AnuragRaut08

@AnuragRaut08 AnuragRaut08 commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Fixes: https://tracker.ceph.com/issues/78958
Signed-off-by: Anurag Raut [email protected]

PR Description:

This PR avoids re-enabling the Telemetry module when it is already enabled.

During the initial Telemetry configuration, the dashboard enables the Telemetry module and applies the selected configuration. For subsequent configuration updates, the dashboard now updates only the configuration without issuing another Telemetry enable request, preventing redundant activation attempts. The success notification is also updated to distinguish between initial activation and subsequent configuration updates, and the user is redirected after a successful operation to prevent repeated submissions.

Screencast:

Screencast.From.2026-08-03.13-25-42.webm

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@afreen23 afreen23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@github-project-automation github-project-automation Bot moved this from New to Reviewer approved in Ceph-Dashboard Aug 3, 2026
@dnyanee1997

Copy link
Copy Markdown
Contributor

jenkins test make check

@dnyanee1997

Copy link
Copy Markdown
Contributor

jenkins test make check arm64

1 similar comment
@AnuragRaut08

Copy link
Copy Markdown
Contributor Author

jenkins test make check arm64

@afreen23
afreen23 merged commit 84f9deb into ceph:main Aug 5, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Ceph-Dashboard Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

This is an automated message by src/script/redmine-upkeep.py.

I have resolved the following tracker ticket due to the merge of this PR:

No backports are pending for the ticket. If this is incorrect, please update the tracker
ticket and reset to Pending Backport state.

Update Log: https://github.com/ceph/ceph/actions/runs/30998912133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants