Conversation
ProxBot
pushed a commit
to proxmox/ceph
that referenced
this pull request
Dec 17, 2025
And also opened a PR on upstream ceph/ceph#66670
Contributor
|
Contributor
|
jenkins test make check arm64 |
Contributor
|
jenkins test api |
14 tasks
14 tasks
The ceph-volume@ service uses the @CMAKE_INSTALL_PREFIX@, so we cannot just install it directly like the target units, but need to process it like all other units that are referring to actual executables that reside in build-target dependent paths. Fixes: 68c72c5 ("systemd: use CMake install prefix in templates") Reported-by: Daniel Herzig <[email protected]> Reported-by: Aaron Lauterer <[email protected]> Signed-off-by: Thomas Lamprecht <[email protected]>
tchaikov
force-pushed
the
systemd-fix-ceph-volume@-service-install
branch
from
e83a5a8 to
2fce003
Compare
Contributor
|
rebased against |
Contributor
|
jenkins test make check |
Collaborator
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ceph-volume@ service uses the @CMAKE_INSTALL_PREFIX@, so we cannot just install it directly like the target units, but need to process as
.infile it like all other units that are referring to actual executables that reside in build-target dependent paths.Fixes: 68c72c5 ("systemd: use CMake install prefix in templates")
Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.