neorados: Fix Neorados CephContext leak and prevent future ones#66368
Open
adamemerson wants to merge 1 commit intoceph:mainfrom
Open
neorados: Fix Neorados CephContext leak and prevent future ones#66368adamemerson wants to merge 1 commit intoceph:mainfrom
adamemerson wants to merge 1 commit intoceph:mainfrom
Conversation
adamemerson
force-pushed
the
wip-neorados-leak
branch
from
d1d3b11 to
f442d0f
Compare
Contributor
Author
|
When this is QAd, it should have RBD, RGW, and Core testing. |
cbodley
reviewed
Nov 21, 2025
cbodley
reviewed
Nov 21, 2025
adamemerson
force-pushed
the
wip-neorados-leak
branch
from
f442d0f to
446b44f
Compare
Contributor
Author
|
jenkins test signed |
cbodley
approved these changes
Dec 3, 2025
Contributor
Author
|
jenkins test api |
bill-scales
approved these changes
Dec 4, 2025
Contributor
https://pulpito.ceph.com/jjperez-2025-12-11_15:57:53-crimson-rados-wip-perezjos-crimson-only-11-12-2025-PR66368-distro-crimson-debug-smithi/
|
perezjosibm
added
wip-perezjos-testing
and removed
needs-crimson-qa
wip-perezjos-testing
labels
Contributor
|
@adamemerson, can we merge this based on the tests above? |
We were getting something with a reference already on it, then taking a second for the RADOS object to own without dropping the first. Fixes: https://tracker.ceph.com/issues/71478 Signed-off-by: Adam C. Emerson <[email protected]>
adamemerson
force-pushed
the
wip-neorados-leak
branch
from
446b44f to
a1a3dc3
Compare
Contributor
Author
It should have an RBD run if there's any way we can manage it. |
Contributor
Author
|
jenkins test api |
Contributor
Author
|
jenkins test windows |
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
|
jenkins test make check |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were getting something with a reference already on it, then taking a second for the RADOS object to own without dropping the first.
Fixes: https://tracker.ceph.com/issues/71478
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.