systemd: Fix ceph-volume@ CMake template processing#65725
systemd: Fix ceph-volume@ CMake template processing#65725
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CMake template processing for the [email protected] systemd unit. A previous change introduced @CMAKE_INSTALL_PREFIX@ substitution that requires files to be processed as CMake templates (.in files), but [email protected] was being installed as-is without template processing.
- Moves
[email protected]from the as-is install list to the template processing list - Ensures CMake variables are properly substituted during build
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
Signed-off-by: Joshua Peek <[email protected]>
josh
force-pushed
the
systemd-cmake-template
branch
from
214ad4d to
cd9ac91
Compare
|
i am closing this pull request, as it duplicates #66670. |
#60575 added a
@CMAKE_INSTALL_PREFIX@substitution which is only processed in.inCMake template files. Most units were fine except thatsystemd/[email protected]which didn't have a.inand is in the as-is files set. This PR fixes the[email protected]unit so any variables are substituted on build.Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.