jenkins test make check

I'll get to this this week, apologies for the delay.

ceph-workspace/main » git grep 'CRUSH_MAX_DEVICE_WEIGHT'
src/crush/CrushCompiler.cc:       if (weight > CRUSH_MAX_DEVICE_WEIGHT && itemid >= 0) {
src/crush/CrushCompiler.cc:         err << "device weight limited to " << CRUSH_MAX_DEVICE_WEIGHT / 0x10000 << std::endl;
src/crush/crush.h:#define CRUSH_MAX_DEVICE_WEIGHT (100u * 0x10000u)

AFAICT, this is truly only used in CrushCompiler.cc to check the parsed weight. I don't see it used in any other context. I'd guess it's actually possible to add a larger device through other crush commands already (@dvanders this is worth checking, there might be other checks like this which don't use this constant).

This should be safe.

RADOS approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues72101

@dvanders - The validation of the PR has been successfully completed. As per the above comment , the review is currently pending. Once the review is done,feel free to merge the PR.

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

jenkins test make check

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@athanatos it is still awaits your review.

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@athanatos @kshtsk I've checked the OSDMonitor commands like crush add, crush set, crush create-or-move, also OSD::update_crush_location, crimson, and cephadm usage of all that. I didn't find any other device size limits.

ceph-workspace/main » git grep 'CRUSH_MAX_DEVICE_WEIGHT'
src/crush/CrushCompiler.cc:       if (weight > CRUSH_MAX_DEVICE_WEIGHT && itemid >= 0) {
src/crush/CrushCompiler.cc:         err << "device weight limited to " << CRUSH_MAX_DEVICE_WEIGHT / 0x10000 << std::endl;
src/crush/crush.h:#define CRUSH_MAX_DEVICE_WEIGHT (100u * 0x10000u)

AFAICT, this is truly only used in CrushCompiler.cc to check the parsed weight. I don't see it used in any other context. I'd guess it's actually possible to add a larger device through other crush commands already (@dvanders this is worth checking, there might be other checks like this which don't use this constant).

This should be safe.

You're right, this applies to crushtool. I'm adding a crushtool test.

jenkins retest this please

testing from @JoshuaGabriel

root@ctest-node-01:/# ceph -s
  cluster:
    id:     701a5c32-128c-11f1-b214-bc24113f050c
    health: HEALTH_OK

  services:
    mon: 4 daemons, quorum ctest-node-01,ctest-node-03,ctest-node-04,ctest-node-02 (age 14s) [leader: ctest-node-01]
    mgr: ctest-node-01.otxeyv(active, since 2m), standbys: ctest-node-04.xtlkfj
    osd: 4 osds: 4 up (since 26s), 4 in (since 50s)

  data:
    pools:   1 pools, 1 pgs
    objects: 2 objects, 577 KiB
    usage:   108 MiB used, 400 GiB / 400 GiB avail
    pgs:     1 active+clean

croot@ctest-node-01:/# ceph osd tree
ID  CLASS  WEIGHT      TYPE NAME               STATUS  REWEIGHT  PRI-AFF
-1         1680.00000  root default
-3          420.00000      host ctest-node-01
 0    ssd   420.00000          osd.0               up   1.00000  1.00000
-9          420.00000      host ctest-node-02
 2    ssd   420.00000          osd.2               up   1.00000  1.00000
-7          420.00000      host ctest-node-03
 1    ssd   420.00000          osd.1               up   1.00000  1.00000
-5          420.00000      host ctest-node-04
 3    ssd   420.00000          osd.3               up   1.00000  1.00000
root@ctest-node-01:/# ceph config dump
WHO     MASK                LEVEL     OPTION                                 VALUE                                                                                                 RO
global                      advanced  osd_crush_initial_weight               420.000000

crushtool seems happy

root@ctest-node-01:/# ceph osd tree
ID  CLASS  WEIGHT      TYPE NAME               STATUS  REWEIGHT  PRI-AFF
-1         1680.00000  root default
-9          420.00000      host ctest-node-01
 2    ssd   420.00000          osd.2               up   1.00000  1.00000
-7          420.00000      host ctest-node-02
 1    ssd   420.00000          osd.1               up   1.00000  1.00000
-3          420.00000      host ctest-node-03
 0    ssd   420.00000          osd.0               up   1.00000  1.00000
-5          420.00000      host ctest-node-04
 3    ssd   420.00000          osd.3               up   1.00000  1.00000
root@ctest-node-01:/# ceph osd getcrushmap -o crush.map
5
root@ctest-node-01:/# crushtool -d crush.map -o crush.txt
root@ctest-node-01:/# vi crush.txt
root@ctest-node-01:/# cat crush.txt  | grep osd.0
device 0 osd.0 class ssd
        item osd.0 weight 421.00000
root@ctest-node-01:/# crushtool -c crush.txt -o crush.map2
root@ctest-node-01:/#