Skip to content

Comments

cmake/common: temporarily remove decode_start_v_checker tests#62902

Merged
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-70700-disable
Apr 23, 2025
Merged

cmake/common: temporarily remove decode_start_v_checker tests#62902
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-70700-disable

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Apr 21, 2025

these test cases appear to be the cause of many 'make check' failures:

error while loading shared libraries: path/to/libceph-common.so.2: file too short

Reported in https://tracker.ceph.com/issues/70700

disable the tests until we can fix them

Show available Jenkins commands

@ljflores
Copy link
Member

ljflores commented Apr 21, 2025 

CTest Failure

2 tests failed out of 312

Total Test time (real) = 7975.24 sec

The following tests FAILED:
	 33 - run-rbd-unit-tests-109.sh (Failed)
	278 - unittest-object-data-handler (Timeout)

@ljflores
Copy link
Member

ljflores commented Apr 21, 2025

jenkins test make check arm64

ljflores
ljflores reviewed Apr 21, 2025
View reviewed changes
src/test/common/CMakeLists.txt
Comment on lines 456 to 460
# Validation of the DECODE_START's struct_v compile-time checker.
# First, ensure buildability of the test program itself. This is
# useful to avoid false positives coming from other-than-the-assert
# build failures.
add_executable(unittest_decode_start_v_checker
Copy link
Member

@ljflores ljflores Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we comment them out and link to the tracker if disabling the tests is temporary? If we plan to remove them permanently, it's fine as is.

@cbodley
cmake/common: temporarily remove decode_start_v_checker tests
e9133c8 
these test cases appear to be the cause of many 'make check' failures:

> error while loading shared libraries: path/to/libceph-common.so.2: file too short

Reported in https://tracker.ceph.com/issues/70700

disable the tests until we can fix them

Signed-off-by: Casey Bodley <[email protected]>
@cbodley cbodley force-pushed the wip-70700-disable branch from 9af4d4d to e9133c8 Compare April 22, 2025 12:21
@cbodley
Copy link
Contributor Author

cbodley commented Apr 22, 2025

https://jenkins.ceph.com/job/ceph-pull-requests/156672/

Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 4140461 (apt-get)

https://jenkins.ceph.com/job/ceph-api/94308/

Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 4140461 (apt-get)

@dmick
Copy link
Member

dmick commented Apr 22, 2025

both apt-get failures were on irvingi08. There was a hung apt-get. I killed it.

@cbodley
Copy link
Contributor Author

cbodley commented Apr 22, 2025

https://jenkins.ceph.com/job/ceph-pull-requests-arm64/72746/

The following tests FAILED:
35 - run-cli-tests (Failed)

opened https://tracker.ceph.com/issues/71027

@cbodley
Copy link
Contributor Author

cbodley commented Apr 22, 2025

jenkins test api

@cbodley
Copy link
Contributor Author

cbodley commented Apr 22, 2025

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Apr 22, 2025

jenkins test make check arm64

@ljflores
Copy link
Member

ljflores commented Apr 22, 2025

jenkins test make check arm64

@cbodley
Copy link
Contributor Author

cbodley commented Apr 23, 2025

i was hoping for a response from Radek before merging, but it's been a couple days and Laura has approved for core

@cbodley cbodley merged commit c55f63b into ceph:main Apr 23, 2025
12 checks passed
@cbodley
Copy link
Contributor Author

cbodley commented Apr 23, 2025

thanks @dmick @ljflores

@rzarzynski
Copy link
Contributor

rzarzynski commented Apr 24, 2025

Thank you for nailing this down and disabling, @cbodley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmick dmick dmick approved these changes

@ljflores ljflores ljflores approved these changes

Assignees

@rzarzynski rzarzynski

Labels

build/ops tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbodley @ljflores @dmick @rzarzynski