Conversation
clwluvw
changed the title
clwluvw
commented
Mar 15, 2025
4 tasks
clwluvw
force-pushed
the
bucket-replication-mismatch
branch
from
2df149a to
d6ec9af
Compare
Reject PutBucketReplication calls if versioning is not identical between the source and destination buckets. This check also applies to object lock configurations to ensure consistency. Fixes: https://tracker.ceph.com/issues/70486 Signed-off-by: Seena Fallah <[email protected]>
As instance field is preserved while replicating, this can make confusion for versioned buckets having non-versioned objects and non-versioned buckets having versioned objects. Fixes: https://tracker.ceph.com/issues/70486 Signed-off-by: Seena Fallah <[email protected]>
replicating lock enabled objects require the destination bucket to have object lock enabled. Fixes: https://tracker.ceph.com/issues/70486 Signed-off-by: Seena Fallah <[email protected]>
clwluvw
force-pushed
the
bucket-replication-mismatch
branch
from
d6ec9af to
826d493
Compare
cbodley
approved these changes
Mar 18, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PutBucketReplicationis now rejecting policies that name a destination bucket with a different status.If the status changes after
PutBucketReplication, the corresponding bucket sync processes will skip those entries.Fixes: https://tracker.ceph.com/issues/70486 (partially - the status change is tracked in #62147)