Skip to content

Comments

mds: set alternate_name for new fullbit dentries#62231

Merged
batrick merged 2 commits intoceph:mainfrom
batrick:mds-alternate_name-recovery
Mar 14, 2025
Merged

mds: set alternate_name for new fullbit dentries#62231
batrick merged 2 commits intoceph:mainfrom
batrick:mds-alternate_name-recovery

Conversation

@batrick
Copy link
Member

@batrick batrick commented Mar 11, 2025 •
edited
Loading

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@batrick batrick changed the title Mds alternate name recovery mds: set alternate_name for new fullbit dentries Mar 11, 2025
@github-actions github-actions bot added the cephfs Ceph File System label Mar 11, 2025
@batrick batrick force-pushed the mds-alternate_name-recovery branch 2 times, most recently from d5ab669 to 88eb9ea Compare March 11, 2025 19:18
@github-actions github-actions bot added the tests label Mar 11, 2025
@batrick batrick force-pushed the mds-alternate_name-recovery branch 2 times, most recently from 4dd1f33 to cd37ca8 Compare March 11, 2025 21:14
@batrick
Copy link
Member Author

batrick commented Mar 11, 2025

This PR is under test in https://tracker.ceph.com/issues/70407.

@batrick batrick force-pushed the mds-alternate_name-recovery branch from cd37ca8 to 0c1b4ab Compare March 12, 2025 00:01
@batrick batrick requested review from a team and vshankar March 12, 2025 00:03
@batrick batrick marked this pull request as ready for review March 12, 2025 00:03
@batrick batrick force-pushed the mds-alternate_name-recovery branch from 0c1b4ab to e2be4ba Compare March 12, 2025 14:38
@batrick batrick mentioned this pull request Mar 12, 2025
Merged
@batrick
Copy link
Member Author

batrick commented Mar 12, 2025

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Mar 12, 2025

jenkins test make check

@batrick batrick force-pushed the mds-alternate_name-recovery branch from e2be4ba to 470ed26 Compare March 12, 2025 17:45
@batrick
Copy link
Member Author

batrick commented Mar 12, 2025

This PR is under test in https://tracker.ceph.com/issues/70426.

@batrick
Copy link
Member Author

batrick commented Mar 13, 2025

jenkins test make check arm64

@github-actions
Copy link

github-actions bot commented Mar 13, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@batrick batrick force-pushed the mds-alternate_name-recovery branch from 470ed26 to 5fc94be Compare March 13, 2025 14:08
@batrick
Copy link
Member Author

batrick commented Mar 13, 2025

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Mar 13, 2025 

Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/services/exception.py", line 77, in handle_rbd_error
    yield
  File "/usr/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/controllers/rbd_mirroring.py", line 512, in set
    return self.set_pool_mirror_mode(pool_name, mirror_mode)
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/controllers/rbd_mirroring.py", line 527, in set_pool_mirror_mode
    return rbd_call(pool_name, None, _edit, mirror_mode)
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/services/rbd.py", line 130, in rbd_call
    return func(ioctx, *args, **kwargs)
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/controllers/rbd_mirroring.py", line 524, in _edit
    rbd.RBD().mirror_mode_set(ioctx, mode_enum)
  File "rbd.pyx", line 1334, in rbd.RBD.mirror_mode_set
rbd.ImageBusy: [errno 16] RBD image is busy (error setting mirror mode)

From: https://jenkins.ceph.com/job/ceph-api/91676/

@batrick
Copy link
Member Author

batrick commented Mar 13, 2025

jenkins test api

2 similar comments
@batrick
Copy link
Member Author

batrick commented Mar 14, 2025

jenkins test api

@batrick
Copy link
Member Author

batrick commented Mar 14, 2025

jenkins test api

@batrick batrick merged commit 912e1a8 into ceph:main Mar 14, 2025
12 checks passed
@batrick batrick deleted the mds-alternate_name-recovery branch March 14, 2025 15:45
@batrick batrick mentioned this pull request Mar 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@kotreshhr kotreshhr kotreshhr approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System needs-review tests wip-pdonnell-testing2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@batrick @vshankar @kotreshhr