Skip to content

Comments

client: avoid multiple calls to path_walk#62230

Merged
batrick merged 1 commit intoceph:mainfrom
batrick:client-path_walk-mkdir
Mar 13, 2025
Merged

client: avoid multiple calls to path_walk#62230
batrick merged 1 commit intoceph:mainfrom
batrick:client-path_walk-mkdir

Conversation

@batrick
Copy link
Member

@batrick batrick commented Mar 11, 2025

When we wrap a dname after a path walk, we cannot do another path walk. Originally this method was setup to permit that but with (upcoming) encryption it cannot work. The dname from the path_walk is in the encrypted namespace so we cannot do another lookup in a second path_walk.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

When we wrap a dname after a path walk, we cannot do another path walk.
Originally this method was setup to permit that but with (upcoming) encryption
it cannot work. The dname from the path_walk is in the encrypted namespace so
we cannot do another lookup in a second path_walk.

Signed-off-by: Patrick Donnelly <[email protected]>
@github-actions github-actions bot added the cephfs Ceph File System label Mar 11, 2025
@batrick
Copy link
Member Author

batrick commented Mar 11, 2025

@batrick
Copy link
Member Author

batrick commented Mar 12, 2025

@batrick batrick requested review from a team and chrisphoffman March 12, 2025 19:54
@batrick batrick merged commit f536650 into ceph:main Mar 13, 2025
16 checks passed
@batrick batrick deleted the client-path_walk-mkdir branch March 13, 2025 15:19
@batrick
Copy link
Member Author

batrick commented Mar 13, 2025

Backported via #62095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants