crimson: fix compile errors in clang 19#61890
Merged
Conversation
Matan-B
reviewed
Feb 19, 2025
Contributor
Matan-B
left a comment
Matan-B
left a comment
There was a problem hiding this comment.
The errors were addressed here: https://github.com/ceph/ceph/pull/61740/commits though it's probably better to have a sperated PR - Thanks for addressing that!
Can you please also cherry pick b08b1f5?
| std::forward<OpFunc>(opfunc), | ||
| std::forward<Params>(params)... | ||
| ).template handle_interruption(std::move(efunc)); | ||
| ).template handle_interruption<OnInterrupt>(std::move(efunc)); |
Contributor
There was a problem hiding this comment.
Removing template should work, what do you think?
).handle_interruption(std::move(efunc));
Contributor
Author
There was a problem hiding this comment.
Will this affect the old compiler? I' not sure whether clang-16 could work.
src/crimson/common/operation.h
Outdated
| class TriggerContainer final : public TriggerI::TriggerContainerI { | ||
| AggregateBlockingEvent& event; | ||
| typename decltype(event.events)::iterator iter; | ||
| typename decltype(std::declval<AggregateBlockingEvent<T>>().events)::iterator iter; |
Contributor
There was a problem hiding this comment.
👍
we could also use std::list<T> instead of declval
Signed-off-by: Zhang Song <[email protected]>
Signed-off-by: Matan Breizman <[email protected]>
```
ceph/src/crimson/common/operation.cc
In file included from /home/matan/ceph/src/crimson/common/operation.cc:4:
/home/matan/ceph/src/crimson/common/operation.h:312:31: error: no member named 'events' in 'AggregateBlockingEvent<T>'
312 | typename decltype(event.events)::iterator iter;
| ~~~~~ ^
1 error generated.
```
Signed-off-by: Matan Breizman <[email protected]>
See: llvm/llvm-project@f46d146 ``` common/interruptible_future.h:1182:16: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw] 1182 | ).template handle_interruption(std::move(efunc)); | ^ 1 error generated. ``` Signed-off-by: Matan Breizman <[email protected]>
Contributor
Author
|
tested with gcc 13 and clang 19 |
Matan-B
approved these changes
Feb 19, 2025
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with clang 19 and gcc 13.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e