crush/CrushWrapper: un-inline methods to fix linker errors#61872
Merged
crush/CrushWrapper: un-inline methods to fix linker errors#61872
Conversation
The `crush_objs` library is not part of the `libceph-common` ABI, so applications linking with `libceph-common` may fail to build because the linker cannot find `crush_destroy()`. Signed-off-by: Max Kellermann <[email protected]>
batrick
approved these changes
Feb 18, 2025
Member
|
jenkins test make check |
zmc
pushed a commit
to zmc/ceph
that referenced
this pull request
Feb 26, 2025
* refs/pull/61872/head: crush/CrushWrapper: un-inline methods to fix linker errors Reviewed-by: Patrick Donnelly <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
crush_objslibrary is not part of thelibceph-commonABI, so applications linking withlibceph-commonmay fail to build because the linker cannot findcrush_destroy().See #61697 (comment) for an instance of the bug fixed by this PR. (@batrick)
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e