Skip to content

Comments

osdc: include cleanup#61697

Merged
batrick merged 7 commits intoceph:mainfrom
MaxKellermann:osdc_includes
Feb 24, 2025
Merged

osdc: include cleanup#61697
batrick merged 7 commits intoceph:mainfrom
MaxKellermann:osdc_includes

Conversation

@MaxKellermann
Copy link
Member

Another PR split from #60490; this time the "osdc" subsystem.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@MaxKellermann
Copy link
Member Author

CI failures due to pre-existing Ceph bugs; fixed by #61701

@batrick
Copy link
Member

batrick commented Feb 17, 2025

jenkins test api

@batrick
Copy link
Member

batrick commented Feb 17, 2025

jenkins test make check

@batrick
Copy link
Member

batrick commented Feb 17, 2025

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented Feb 17, 2025

jenkins test windows

@batrick
Copy link
Member

batrick commented Feb 17, 2025

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

The `crush_objs` library is not part of the `libceph-common` ABI, so
applications linking with `libceph-common` may fail to build because
the linker cannot find `crush_destroy()`.

Signed-off-by: Max Kellermann <[email protected]>
Signed-off-by: Max Kellermann <[email protected]>
@batrick batrick merged commit 3edb990 into ceph:main Feb 24, 2025
11 checks passed
@MaxKellermann MaxKellermann deleted the osdc_includes branch February 25, 2025 06:34
zmc pushed a commit to zmc/ceph that referenced this pull request Feb 26, 2025
* refs/pull/61697/head:
	osdc/ObjectCacher: include cleanup
	osdc/Objecter: include cleanup
	osdc/Journaler: include cleanup
	osdc/Striper: add missing includes
	osdc/Filer: include cleanup
	crush/CrushWrapper: un-inline methods to fix linker errors
	client/Client: add missing include and forward declaration

Reviewed-by: Patrick Donnelly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants