Skip to content

Comments

tools: add missing includes#61695

Merged
idryomov merged 1 commit intoceph:mainfrom
MaxKellermann:tools_includes
Feb 12, 2025
Merged

tools: add missing includes#61695
idryomov merged 1 commit intoceph:mainfrom
MaxKellermann:tools_includes

Conversation

@MaxKellermann
Copy link
Member

Split from #61682 and #60490 (as requested by @idryomov)

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

@MaxKellermann MaxKellermann requested review from a team as code owners February 7, 2025 11:39
@github-actions github-actions bot added cephfs Ceph File System core rbd labels Feb 7, 2025
This was referenced Feb 7, 2025
Signed-off-by: Max Kellermann <[email protected]>
@idryomov
Copy link
Contributor

idryomov commented Feb 7, 2025

Split from #61682 and #60490 (as requested by @idryomov)

My implicit suggestion was to split by component (RADOS, RBD, CephFS, etc), not by source directory. Anything is fine here since this just massages includes, but I wanted to clarify for the future -- PRs that touch only a single component often move faster because there is less coordination involved.

Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack from the RBD perspective

@idryomov idryomov requested a review from a team February 7, 2025 15:51
@MaxKellermann
Copy link
Member Author

My implicit suggestion was to split by component (RADOS, RBD, CephFS, etc), not by source directory.

Yes, I understood that, and that's what I've been trying to do all along. PR #61608 only got unrelated commits because it turned out that it caused build failures in other components that needed to be fixed prior to merging it; and adding the fixup commits for these other components was just an intermediate experiment to see if that's enough to make the CI happy.

@idryomov
Copy link
Contributor

jenkins test make check

@idryomov
Copy link
Contributor

CephFS bits were approved by @batrick in #61608, merging.

@idryomov idryomov merged commit dae433c into ceph:main Feb 12, 2025
12 checks passed
@idryomov idryomov mentioned this pull request Feb 12, 2025
14 tasks
@MaxKellermann MaxKellermann deleted the tools_includes branch February 12, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System core rbd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants