include: interval_set: Re-introduce the original behaviour strict interval set#61693
Merged
include: interval_set: Re-introduce the original behaviour strict interval set#61693
Conversation
…default. The strict behaviour can be turned off in the template. Signed-off-by: Alex Ainscow <[email protected]>
aainscow
force-pushed
the
interval_set_strict
branch
from
310a2fb to
0c57b71
Compare
Contributor
|
Added bluestore label - BlueStore uses interval_set extensively. |
aainscow
changed the title
Contributor
Author
|
jenkins test api |
Contributor
zmc
pushed a commit
to zmc/ceph
that referenced
this pull request
Feb 26, 2025
include: interval_set: Re-introduce the original behaviour strict interval set
aainscow
added
the
no-backport-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 60250 introduced a new interval set insert function that was less strict than the default insert. A less strict erase overload was also introduced.
The new overloaded erase is considered too relaxed for existing purposes.
The new solution is to introduce a templated "strict" mode - which is on my default.
I have also enhanced the test harness to assert that using the strict insert actually corrupts things.
I have also used this PR to provide a fix for tracker 69862
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e