mds: include cleanup by MaxKellermann · Pull Request #61682 · ceph/ceph

MaxKellermann · 2025-02-06T19:39:23Z

Another PR split from #60490; this time the "mds" subsystem.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

github-actions · 2025-02-06T19:39:39Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

MaxKellermann · 2025-02-06T19:40:50Z

@batrick I guess this is one for you to review?

idryomov

This appears to have the same RBD changes as #61608. If there is some dependency that makes them hard to separate, let's at least keep them in a single "unrelated" PR ;)

MaxKellermann · 2025-02-07T11:31:58Z

If there is some dependency that makes them hard to separate, let's at least keep them in a single "unrelated" PR

The first commit is important or else the tools fail to build after the MDS header corrections.

But sure I can split this one out into a separate PR. I put it here because every PR I submit to Ceph takes several months to merge, so PRs lik e this one would take twice as long if they depend on another PR.

MaxKellermann · 2025-02-07T11:47:56Z

@idryomov the "tools" commit as separate PR here: #61695

Once this is merged, I'll rebase this PR (which drops already-mergede commits).

github-actions · 2025-02-12T09:05:42Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

MaxKellermann · 2025-02-12T12:08:02Z

@idryomov rebased this one, too - the unrelated "tools" commit was already merged, and only MDS-related commits remain here.

idryomov · 2025-02-12T12:20:32Z

only MDS-related commits remain here.

Thanks, this would be in @batrick or @ceph/CephFS hands.

batrick

🥇

batrick · 2025-02-17T19:00:32Z

jenkins test make check

batrick · 2025-02-17T19:00:36Z

jenkins test make check arm64

batrick · 2025-02-17T19:00:42Z

jenkins test api

batrick · 2025-02-17T19:11:55Z

This PR is under test in https://tracker.ceph.com/issues/70002.

Signed-off-by: Max Kellermann <[email protected]>

batrick · 2025-02-24T21:40:14Z

jenkins test make check

batrick · 2025-02-24T21:40:20Z

jenkins test make check arm64

batrick · 2025-02-25T02:31:39Z

This PR is under test in https://tracker.ceph.com/issues/70157.

batrick · 2025-02-25T15:56:04Z

jenkins test make check arm64

batrick · 2025-02-25T21:32:59Z

https://tracker.ceph.com/issues/70157#note-2

batrick · 2025-02-25T21:59:33Z

This PR is under test in https://tracker.ceph.com/issues/70176.

batrick · 2025-02-26T13:12:26Z

281/302 Test #273: unittest-seastore-cbjournal ...............   Passed  198.97 sec
282/302 Test  #30: run-rbd-unit-tests-0.sh ...................   Passed  1284.91 sec
283/302 Test #200: unittest_bluestore_types ..................   Passed  894.01 sec
284/302 Test #302: run-promtool-unittests ....................   Passed   87.37 sec
285/302 Test #207: safe-to-destroy.sh ........................   Passed  834.64 sec
286/302 Test  #33: run-rbd-unit-tests-109.sh .................   Passed  1374.45 sec
287/302 Test #275: unittest-staged-fltree ....................   Passed  320.55 sec
288/302 Test #156: check-generated.sh ........................   Passed  1330.72 sec
289/302 Test #264: unittest-btree-lba-manager ................   Passed  825.07 sec
290/302 Test  #34: run-rbd-unit-tests-127.sh .................   Passed  2014.84 sec
291/302 Test #178: unittest_erasure_code_shec_all ............   Passed  2006.21 sec
292/302 Test  #31: run-rbd-unit-tests-1.sh ...................   Passed  2761.64 sec
293/302 Test   #4: run-tox-mgr ...............................   Passed  2684.84 sec
        Start   3: teardown-venv-for-mgr
294/302 Test   #3: teardown-venv-for-mgr .....................   Passed    2.33 sec
295/302 Test  #52: unittest_bufferlist .......................   Passed  2742.20 sec
296/302 Test #276: unittest-fltree-onode-manager .............   Passed  1821.27 sec
297/302 Test  #32: run-rbd-unit-tests-61.sh ..................   Passed  3344.28 sec
298/302 Test #270: unittest-seastore .........................   Passed  3436.90 sec
299/302 Test #267: unittest-object-data-handler ..............   Passed  4215.01 sec
300/302 Test #157: readable.sh ...............................   Passed  6062.26 sec
301/302 Test #269: unittest-omap-manager .....................   Passed  5975.98 sec
Terminated
Build step 'Execute shell' marked build as failure
[Cobertura] Skipping Cobertura coverage report as build was not SUCCESS or better ...

[PostBuildScript] - [INFO] Executing post build scripts.
[PostBuildScript] - [INFO] Build does not have any of the results [ABORTED]. Did not execute build step #0.
INFO: Processing CTest-Version 3.x (default)
INFO: [CTest-Version 3.x (default)] - No test report file(s) were found with the pattern 'build/Testing/**/Test.xml' relative to '/home/jenkins-build/build/workspace/ceph-pull-requests-arm64' for the testing framework 'CTest-Version 3.x (default)'.
Did you enter a pattern relative to (and within) the workspace directory?
Did you generate the result report(s) for 'CTest-Version 3.x (default)'?"
WARNING: All test reports are empty.
INFO: Check 'Failed Tests' threshold.
[Checks API] No suitable checks publisher found.
INFO: Setting the build status to SUCCESS
[Checks API] No suitable checks publisher found.
Setting status of 80b0065fd7196a5e96102a4dd61dd6fecdfda122 to FAILURE with url https://jenkins.ceph.com/job/ceph-pull-requests-arm64/68952/ and message: 'make check failed
 '
Using context: make check (arm64)
Finished: FAILURE

batrick · 2025-02-26T13:12:32Z

jenkins test make check arm64

batrick · 2025-02-26T14:15:42Z

This PR is under test in https://tracker.ceph.com/issues/70184.

batrick · 2025-02-26T18:17:22Z

This PR is under test in https://tracker.ceph.com/issues/70189.

batrick · 2025-02-27T00:03:31Z

This PR is under test in https://tracker.ceph.com/issues/70195.

batrick · 2025-02-27T02:28:41Z

This PR is under test in https://tracker.ceph.com/issues/70197.

batrick · 2025-02-27T18:18:54Z

he following tests FAILED:
	263 - unittest-transaction-manager (Timeout)

batrick · 2025-02-27T18:19:03Z

jenkins test make check arm64

* refs/pull/61682/head: mds/snap: include cleanup mds/MetricsHandler: include cleanup mds/LogSegment: add missing includes mds/JournalPointer: include cleanup mds/cephfs_features: include cleanup mds/MDSMap: include cleanup mds/Migrator: include cleanup mds/MDLog: include cleanup mds/SnapServer: include cleanup mds/MDSTableServer: include cleanup mds/MetricAggregator: include cleanup mds/SnapClient: include cleanup mds/MDSPinger: include cleanup mds/flock: include cleanup mds/MDSAuthCaps: include cleanup mds/QuiesceAgent: include cleanup mds/QuiesceDb: include cleanup mds/mdstypes: include cleanup msg/Locker: include cleanup mds/journal: add missing includes mds/Server: include cleanup mds/LogEvent: include cleanup mds/Capability: include cleanup mds/DamageTable: include cleanup mds/StrayManager: include cleanup mds/Mutation: include cleanup mds/SnapRealm: include cleanup mds/InoTable: add missing include mds/ScatterLock: add missing include mon/MDSMonitor: add missing include mon/MDSDaemon: add missing include

batrick · 2025-02-27T19:12:09Z

This PR is under test in https://tracker.ceph.com/issues/70218.

* refs/pull/61682/head: mds/snap: include cleanup mds/MetricsHandler: include cleanup mds/LogSegment: add missing includes mds/JournalPointer: include cleanup mds/cephfs_features: include cleanup mds/MDSMap: include cleanup mds/Migrator: include cleanup mds/MDLog: include cleanup mds/SnapServer: include cleanup mds/MDSTableServer: include cleanup mds/MetricAggregator: include cleanup mds/SnapClient: include cleanup mds/MDSPinger: include cleanup mds/flock: include cleanup mds/MDSAuthCaps: include cleanup mds/QuiesceAgent: include cleanup mds/QuiesceDb: include cleanup mds/mdstypes: include cleanup msg/Locker: include cleanup mds/journal: add missing includes mds/Server: include cleanup mds/LogEvent: include cleanup mds/Capability: include cleanup mds/DamageTable: include cleanup mds/StrayManager: include cleanup mds/Mutation: include cleanup mds/SnapRealm: include cleanup mds/InoTable: add missing include mds/ScatterLock: add missing include mon/MDSMonitor: add missing include mon/MDSDaemon: add missing include

MaxKellermann requested review from a team as code owners February 6, 2025 19:39

github-actions bot added cephfs Ceph File System core mon rbd labels Feb 6, 2025

github-actions bot added the needs-rebase label Feb 6, 2025

MaxKellermann force-pushed the mds_includes branch from a5f37b4 to 71b8138 Compare February 6, 2025 19:40

github-actions bot removed the needs-rebase label Feb 6, 2025

MaxKellermann changed the title ~~Mds includes~~ mds: include cleanup Feb 6, 2025

idryomov reviewed Feb 7, 2025

View reviewed changes

MaxKellermann mentioned this pull request Feb 7, 2025

tools: add missing includes #61695

Merged

14 tasks

idryomov requested a review from a team February 7, 2025 15:53

github-actions bot added the needs-rebase label Feb 12, 2025

MaxKellermann force-pushed the mds_includes branch from 71b8138 to e5aed43 Compare February 12, 2025 12:06

github-actions bot removed the needs-rebase label Feb 12, 2025

batrick approved these changes Feb 17, 2025

View reviewed changes

batrick added needs-qa wip-pdonnell-testing labels Feb 17, 2025

MaxKellermann added 10 commits February 20, 2025 16:45

mds/MDSTableServer: include cleanup

7c673c3

Signed-off-by: Max Kellermann <[email protected]>

mds/SnapServer: include cleanup

b13022f

Signed-off-by: Max Kellermann <[email protected]>

mds/MDLog: include cleanup

c510cde

Signed-off-by: Max Kellermann <[email protected]>

mds/Migrator: include cleanup

0ca2e4f

Signed-off-by: Max Kellermann <[email protected]>

mds/MDSMap: include cleanup

00b1173

Signed-off-by: Max Kellermann <[email protected]>

mds/cephfs_features: include cleanup

f5b2171

Signed-off-by: Max Kellermann <[email protected]>

mds/JournalPointer: include cleanup

7e84be8

Signed-off-by: Max Kellermann <[email protected]>

mds/LogSegment: add missing includes

dbba446

Signed-off-by: Max Kellermann <[email protected]>

mds/MetricsHandler: include cleanup

36aae82

Signed-off-by: Max Kellermann <[email protected]>

mds/snap: include cleanup

80b0065

Signed-off-by: Max Kellermann <[email protected]>

MaxKellermann force-pushed the mds_includes branch from 460cd65 to 80b0065 Compare February 20, 2025 15:49

batrick merged commit 54f7b27 into ceph:main Feb 28, 2025
10 of 11 checks passed

MaxKellermann deleted the mds_includes branch February 28, 2025 06:22

Comments

Conversation

MaxKellermann commented Feb 6, 2025

Checklist

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

MaxKellermann commented Feb 6, 2025

Uh oh!

idryomov left a comment

Choose a reason for hiding this comment

Uh oh!

MaxKellermann commented Feb 7, 2025

Uh oh!

MaxKellermann commented Feb 7, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

MaxKellermann commented Feb 12, 2025

Uh oh!

idryomov commented Feb 12, 2025

Uh oh!

batrick left a comment

Choose a reason for hiding this comment

Uh oh!

batrick commented Feb 17, 2025

Uh oh!

batrick commented Feb 17, 2025

Uh oh!

batrick commented Feb 17, 2025

Uh oh!

batrick commented Feb 17, 2025

Uh oh!

batrick commented Feb 24, 2025

Uh oh!

batrick commented Feb 24, 2025

Uh oh!

batrick commented Feb 25, 2025

Uh oh!

batrick commented Feb 25, 2025

Uh oh!

batrick commented Feb 25, 2025

Uh oh!

batrick commented Feb 25, 2025

Uh oh!

batrick commented Feb 26, 2025

Uh oh!

batrick commented Feb 26, 2025

Uh oh!

batrick commented Feb 26, 2025

Uh oh!

batrick commented Feb 26, 2025

Uh oh!

batrick commented Feb 27, 2025

Uh oh!

batrick commented Feb 27, 2025

Uh oh!

batrick commented Feb 27, 2025

Uh oh!

batrick commented Feb 27, 2025

Uh oh!

batrick commented Feb 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants